e2e: Remove broken OpenTable test #95674
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test has been broken for some time now, since upstream has changed the private API we had been using. Time to disable it, so as not to accidentally hide failures in anything that gets tested after it. See Automattic/jetpack#39410 for details.
anomiex
added
[Pri] Normal
[Status] Needs Review
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
tbradsha
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
I can confirm the test is consistently broken in trunk (I've also seen it in E2E tests), and that this branch disables the broken test.
Also, this cuts nearly 2 minutes off of the test suite run (which had 10x retries, all of which would fail!), which would run twice in TeamCity.
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The test has been broken for some time now, since upstream has changed the private API we had been using. Time to disable it, so as not to accidentally hide failures in anything that gets tested after it.
See Automattic/jetpack#39410 for details.
Why are these changes being made?
See above
Testing Instructions
test/e2e/specs/blocks/blocks__jetpack-earn.tsagainst various sites, see that it completes successfully.Pre-merge Checklist